refactor: split AbstractConnectionResolver::get_ids() into ::prepare_ids()

[justlevine]

What does this implement/fix? Explain your changes.

The PR refactors AbstractConnectionResolver in the following ways:

• ::get_ids() now instantiates AbstractConnectionResolver::$ids, only once.
• The ID preparation logic has been moved into a new ::prepare_ids() method.

This improves the DX by reducing the amount of boilerplate needed when extending the AbstractConnectionResolver class, and improving lifecycle consistency, with potential performance benefits for child classes with complex ID preparation logic.

There are no breaking changes in this PR.

Important

This PR requires #3121 which should be merged first.

The relevant diff for this PR can be seen at f6babda

Does this close any currently open issues?

Part of #2749

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

• AbstractConnectionResolver::$ids is still manually instantiated and graphql_connection_ids manually applied in ::execite_and_get_ids() to maintain b/c compatibility with classes that are currently overloading ::get_ids() directly. Similarly, other methods that directly use AbstractConnectionResolver::$ids have not been changed to use ::get_ids().

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + php8.1.15)

WordPress Version: 6.5.2

[codeclimate]

Code Climate has analyzed commit f6babda and detected 0 issues on this pull request.

View more on Code Climate.

[coveralls]

coverage: 84.35% (+0.02%) from 84.33%
when pulling f6babda on justlevine:dev/prepare_ids
into cb18964 on wp-graphql:develop.

The merge-base changed after approval.