Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: relocate AbstractConnectionResolver::is_valid_offset() with other abstract methods. #3122

Merged
merged 1 commit into from
May 8, 2024
Merged

chore: relocate AbstractConnectionResolver::is_valid_offset() with other abstract methods. #3122

merged 1 commit into from
May 8, 2024

Conversation

justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR moves the abstract AbstractConnectionResolver::is_valid_offset() method to be alongside the other abstract methods in the class.

No actual code changes were made in this PR

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

Part of #2749

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + php 8.1.15)

WordPress Version: 6.5.2

@justlevine justlevine requested a review from jasonbahl May 4, 2024 01:49
@codeclimate CodeClimate
Copy link

codeclimate bot commented May 4, 2024

Code Climate has analyzed commit e10139e and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine added Status: In Review Needs to be reviewed by a project maintainer before merge Needs: Reviewer Response This needs the attention of a codeowner or maintainer. Component: Connections Issues related to connections Type: Chore (updating CI tasks etc; no production code change) scope: code quality Affects codebase complexity and maintainability labels May 4, 2024
@coveralls
Copy link

Coverage Status

coverage: 84.33%. remained the same
when pulling e10139e on justlevine:chore/group-abstract-methods
into cb18964 on wp-graphql:develop.

@justlevine justlevine mentioned this pull request May 4, 2024
Draft
8 tasks
@jasonbahl jasonbahl merged commit f400391 into wp-graphql:develop May 8, 2024
30 checks passed
@justlevine justlevine deleted the chore/group-abstract-methods branch May 8, 2024 15:48
@jasonbahl jasonbahl mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbahl jasonbahl jasonbahl approved these changes

Assignees
No one assigned
Labels
Component: Connections Issues related to connections Needs: Reviewer Response This needs the attention of a codeowner or maintainer. scope: code quality Affects codebase complexity and maintainability Status: In Review Needs to be reviewed by a project maintainer before merge Type: Chore (updating CI tasks etc; no production code change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justlevine @coveralls @jasonbahl