Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add graphql_debug warning when using hasPublishedPosts: ATTACHMENT #2964

Conversation

justlevine
Copy link
Collaborator

What does this implement/fix? Explain your changes.

This PR logs a GraphQL debug warning when using users( where: {hasPublishedPosts: ATTACHMENT } ){}, as WP_User_Query() does not support that value.

⚠️ This PR includes #2962 , which should be merged first.

Does this close any currently open issues?

Part of #2963

Any relevant logs, error output, GraphiQL screenshots, etc?

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04 (wsl2 + devilbox + PHP 8.1.15 )

WordPress Version: 6.3.1

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2023

Code Climate has analyzed commit 193d9ab and detected 0 issues on this pull request.

View more on Code Climate.

@justlevine justlevine changed the title dev: Add graphql_debug warning when using hasPublishedPosts: ATTACHMENT fix: Add graphql_debug warning when using hasPublishedPosts: ATTACHMENT Oct 7, 2023
@justlevine justlevine added Type: Bug Something isn't working Status: In Review Needs to be reviewed by a project maintainer before merge Component: Connections Issues related to connections ObjectType: User labels Oct 7, 2023
@coveralls
Copy link

Coverage Status

coverage: 84.695% (-0.05%) from 84.742% when pulling 193d9ab on justlevine:dev/warning-has_published_posts-attachment-arg into 5d69454 on wp-graphql:develop.

jasonbahl
jasonbahl previously approved these changes Oct 10, 2023
@justlevine justlevine dismissed jasonbahl’s stale review October 10, 2023 21:29

The merge-base changed after approval.

@jasonbahl jasonbahl merged commit 7d7582b into wp-graphql:develop Oct 10, 2023
27 of 28 checks passed
@justlevine justlevine deleted the dev/warning-has_published_posts-attachment-arg branch October 10, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Connections Issues related to connections ObjectType: User Status: In Review Needs to be reviewed by a project maintainer before merge Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants