User connections hasPublishedPosts should not allow ATTACHMENT value

[justlevine]

Description

The UserConnectionWhereArgs.hasPublishedPosts is currently of type ContentTypeEnum, which offers ATTACHMENT as a possible value.

However, the underling has_published_posts query arg does not support filtering by attachment.

$query = new \WP_User_Query( [
  'has_published_posts' => 'attachment'
] );

error_log( print_r( $query->get_results() ) ); // will always return an empty array.

This is confirmed in our test suite (part of #2996) as well.

As a quick "fix", I recommend adding a graphql_debug() message alerting users to the bug.

Long term, I suggest we deprecate hasPublishedPosts in favor of something like hasPublishedContent, which uses an enum type that doesnt include attachments.

Steps to reproduce

1. Create an attachment for a specific user and post:

$attachment_id = wp_insert_attachment(
	[
		'post_author' => $user_id,
		'post_type'   => 'attachment',
		'post_status' => 'inherit',
		'post_title'  => 'Test attachment for PostTypeQueryForMedia',
		'post_parent' => $post_id,
	]
);

2. Query for users with hasPublishedPosts: ATTACHMENT:

query {
  users ( where: { hasPublishedPosts: ATTACHMENT } ) {
    nodes {
      databaseId
    }
  }
}

3. Confirm no users are returned.

Additional context

I didnt create a PR to deprecate hasPublishedPosts and create hasPublishedContent because I'm thinking that a "sans-attachment" enum is likely necessary/useful in other parts of the codebase 🤔

WPGraphQL Version

1.16.0

WordPress Version

6.3.1

PHP Version

8.1.15

Additional environment details

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have disabled ALL plugins except for WPGraphQL.

• Yes
• My issue is with compatibility with a specific WordPress plugin, and I have listed all my installed plugins (and version info) above.