Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/acf required #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andrewminion-luminfire
Copy link

If a field group is set to not display in GraphQL, it seems that the GraphQL name should not be required.

This change adds PHP and JS functionality to toggle the name field required attribute based on the “Show in GraphQL” field setting.

@jasonbahl
Copy link
Contributor

Oh nice! I like this idea for sure.

I think there's a lot we can do with JS on that page to help users, like make sure the GraphQL Field Name is unique in the Schema as well.

I'll review this shortly.

@andrewminion-luminfire
Copy link
Author

Just updated wp_register_script to optimize the JS loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants