clients/js: fix low gas budget in Sui VAA submit. #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scnale
requested review from
kcsongor,
kev1n-peters and
evan-gray
as code owners
bruce-riley
approved these changes
Jul 31, 2023
kcsongor
reviewed
Aug 1, 2023
| @@ -38,6 +38,7 @@ export const executeTransactionBlock = async ( | |||
| const consoleWarnTemp = console.warn; | |||
| console.warn = () => {}; | |||
|
|
|||
| transactionBlock.setGasBudget(100_000_000); | |||
There was a problem hiding this comment.
a comment pointing to an explorer link for a successful transaction would be nice to give some context to this number
There was a problem hiding this comment.
Yeah, when I made this change I was actually copying what the sdk already did at that point but I think we should have proper gas estimation instead.
evan-gray
force-pushed
the
fix/sui-worm-submit-low-gas-budget
branch
from
2dfce6f
to
94f5491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default gas budget for Sui transaction blocks is
1_000_000which is too low to submit VAAs.