[WIP] Support Celo native's credit and debit gas fee functions #3162
Conversation
martinvol
commented
Jul 3, 2023
•
martinvol
commented
- Add modifier so that only vm can call
- Add modifier so that it can only be called on Celo (by checking Celo Registry address has bytecode)
- Add credit and debit functions
- Add Fundry tests
- Check with wormhole team how to refactor to comply with repo guidelines
martinvol
requested review from
a5-pickle,
calebrate,
gator-boi,
hendrikhofstadt and
kcsongor
as code owners
martinvol
changed the title
| /** | ||
| * @notice Reverts for non-Celo chains | ||
| */ | ||
| modifier onlyCeloChains() { |
There was a problem hiding this comment.
Perhaps we should use the Wormhole chain id here.
There was a problem hiding this comment.
Or maybe not because this is in the token 🤔
There was a problem hiding this comment.
A few of us have discussed how to include this change in the existing TokenImplementation contract.
How do you feel about creating a second TokenImplementation contract with the Celo-specific functionality that inherits from the existing contract? This way the Celo-specific code is not deployed to other blockchains when the TokenImplementation contract is upgraded.
|
Yeah, makes sense. My original intention with this PR was to pull it in front of your team so you could suggest me the better course of action. Even if this code gets deployed only on Celo, I'd still include the checks to make sure the chain is actually Celo compatible. |
|
@martinvol do you still want to work on this? |
