fix issue with global environment CU-8677zdvv4 #63
Conversation
There was a problem hiding this comment.
Hi @randrescastaneda , I just added a couple of trivial suggestions
R/aaa.R
Outdated
| #~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| ## Evaluate if exists -------- | ||
|
|
||
| to_set <- 1 | ||
| if (rlang::env_has(.pip, table)) { | ||
| if (force == FALSE) { | ||
| if (replace == FALSE) { |
There was a problem hiding this comment.
Can we use isFALSE function here as we do it at other places?
There was a problem hiding this comment.
Good idea. Yes
R/utils.R
Outdated
| #' | ||
| #' @return data frame with new names | ||
| #' @keywords internal | ||
| renamecols <- function(df, oldnames, newnames) { |
There was a problem hiding this comment.
Change the name to rename_cols for consistency with other functions in the package ?
There was a problem hiding this comment.
Yes. Good idea.
Hi @shahronak47 , good suggestions. Could you please implement them? I can't right now. If you can't, I'll do it in a few hours. Thanks! |
HI Ronak. I just implemented your suggestions. |
randrescastaneda
changed the title
randrescastaneda
changed the title
randrescastaneda
changed the title
Hi @tonyfujs,
I think this PR is ready to merge. It solves the issue of the caching. The only thing that is missing is the ability to turn the caching on or off. I just thought about it. I don't think that is super important, either is it too difficult to implement. @shahronak47 , could you please take a look and let me know?
Thanks.
Best,