Fill value #41
Open
Fill value #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g4brielvs
force-pushed
the
main
branch
8 times, most recently
from
86d4f6b
to
d3338cb
Compare
g4brielvs
requested changes
Feb 12, 2024
g4brielvs
force-pushed
the
main
branch
3 times, most recently
from
723c608
to
f660bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quality_flag_rmparameter (eg, when is 255), but this caused some confusing things. For example, when using gap filled daily values, the quality flag is 255 when quality filled -- because the quality is for that day, specifically. The expected default output with gap filled is having the gap filled values. So modified code to take "255" out of quality flag, and instead apply the "fill value" (based on documentation) to each variable. I tried to follow an approach of usingdataset.attrs.get, but didn't see the fill value as a function. Now I think "quality_flag_rm" options make more sense, as they're all quality -- as fill values are bit different, and think always want to remove.