-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin: Bar sound widget and control #329
base: master
Are you sure you want to change the base?
Conversation
Ability to list all windows in workspace. Click action on titles.
Changes LoadFile to LoadFrom to load DLLs included by plugins
Feat/title widget multi window titles
This is a big serious PR! Nice one! I really don't think I can do a full test of the functionality here, given how I no longer run Windows as my primary OS. That said, this is too much good work to pass off 😄 So I'll try to come up with some constructive feedback, and if no other maintainer shows up, we'll just merge it none the same. If this change for whatever reasons causes isseus, whoever runs "unstable" channel should be prepared for things not being 100% reliable anyway 😄 |
@denjukebox You mean, like... no windows shell at all? How to do that? |
This was common practice on the Windows NT/XP world, it was just a question of replacing a registry key. I've searched this topic for Windows 11 and it seems a bit more complicated but still doable. https://learn.microsoft.com/en-us/windows/configuration/kiosk-shelllauncher |
When using workspacer as replacement for the windows shell, the sound key binds (volume/mute) are lost. This PR adds back this functionality using the following library NetCoreAudio that provides all the hooks into windows. It uses the same MIT licence as workspacer so usage is permitted. Beside this it also provides a bar widget that can follow default device changes and is configurable and expandable it its presentation.
A outside change was needed in the keybinding class to allow binding without modifier (KeyModifiers.None)