Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Bar sound widget and control #329

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

denjukebox
Copy link
Contributor

@denjukebox denjukebox commented Jul 29, 2022

When using workspacer as replacement for the windows shell, the sound key binds (volume/mute) are lost. This PR adds back this functionality using the following library NetCoreAudio that provides all the hooks into windows. It uses the same MIT licence as workspacer so usage is permitted. Beside this it also provides a bar widget that can follow default device changes and is configurable and expandable it its presentation.

A outside change was needed in the keybinding class to allow binding without modifier (KeyModifiers.None)

@josteink
Copy link
Member

josteink commented Aug 1, 2022

This is a big serious PR! Nice one!

I really don't think I can do a full test of the functionality here, given how I no longer run Windows as my primary OS. That said, this is too much good work to pass off 😄

So I'll try to come up with some constructive feedback, and if no other maintainer shows up, we'll just merge it none the same.

If this change for whatever reasons causes isseus, whoever runs "unstable" channel should be prepared for things not being 100% reliable anyway 😄

@marad
Copy link
Contributor

marad commented Oct 18, 2022

When using workspacer as replacement for the windows shell

@denjukebox You mean, like... no windows shell at all? How to do that?

@jbrazio
Copy link

jbrazio commented Oct 31, 2022

This was common practice on the Windows NT/XP world, it was just a question of replacing a registry key. I've searched this topic for Windows 11 and it seems a bit more complicated but still doable.

https://learn.microsoft.com/en-us/windows/configuration/kiosk-shelllauncher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants