Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

SEU line number commands GUI start (WIP) #13

Open
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

NathanielACollier
Copy link

@NathanielACollier NathanielACollier commented Dec 9, 2017

This is to make it possible to enter commands per line number. This is a work in progress.

Here are the tasks needed that I can think of to merge:

  • Bug Fix with a document having only 1 line does not show the line numbers, and when you add lines the line numbers start at 3.
  • Initial work to show textboxes when mouse hovers over a line number
  • Needs to be just as fast as the regular line number margin. Right now scrolling and other interaction is noticeably slow.
  • There seems like a bug with line numbers sometimes not being in the right order. The model driven approach may have overlooked something.
  • Figure out why my pull request has a merge I did on my fork to update from WorksOfBarry/ILEditor
  • Bug Fix to show the line numbers in the beginning
  • Bug Fix needed to make typeing more text than available in textbox either make margin wider or just fix the width of the textbox so that overflow text is out of visibility.
  • UI Work to make the line numbers be right adjusted instead of left adjusted (To match AvalonEdit default)
  • UI Work to make the line number margin wider (Maybe 2 or 3 extra character lengths)
  • UI Work to make it where they don't immediately switch back to line number when mouse leaves textbox
  • Events or something to trigger when a user has pressed enter in a command or however it needs to work
  • UI Work showing/hiding text command entry, command display
  • Implement d
  • Implement dd
  • Implement i
  • Implement i of n (i2, i3, in, etc...) - Inserting n lines instead of just 1
  • Implement arrow key to the right inside CommandText textbox makes cursor go to line number in AvalonEdit, and hides command mode.
  • Implement arrow key to the left inside AvalonEdit show CommandTextbox and put cursor inside it
  • Implement up and down arrow keys move up and down line number commands, closing the one they left as they go. Will have to use events to signal up or down

NathanielACollier and others added 11 commits December 9, 2017 08:55
Starting the initial code for textboxes where commands can be entered per line
Got it to look right, but it's really slow and the textbox isn't clickable
It wasn't interactive because it wasn't added to the visual children
… numbers

This resullted in major speed improvement.  This will also allow keeping commands on non visible line numbers.
Lots more options are availble with this type approach
NathanielACollier added a commit to NathanielACollier/AvalonEdit.Pieces.LineNumberMarginCommands that referenced this pull request Dec 13, 2017
It's a really great examplle so need to make all those changes here that I made at this place: worksofliam/ILEditor#13
NathanielACollier and others added 18 commits December 18, 2017 11:17
…line number margin width

Trying to rely on wpf to do width as much as possible.
Using the SizeChanged event on listview to remeasure and give notice that width has changed, if it has...
This is to get it to display command textbox when mouse over line number textblock
…hen hit enter

Without that you'd have to type the command, loose focus, enter focus, then hit enter.

d was being entered, then enter, but the command processing saw it as a blank command because the update source trigger was default of loose focus instead of propertychanged
…cases

Split out Delete Line into it's own function because we will call that to implement d.  We'll also end up making Insert line and calling it multiple times for i and i<n>
NathanielACollier and others added 9 commits January 10, 2018 12:59
dd needs to take a first point and a last point and delete all lines in between
# Conflicts:
#	ILEditor/ILEditor.csproj
Added some notes about how the signaling is going to work using the model as a third party between the GUI of avalonedit, and the GUI of the command (Line number display)
@worksofliam
Copy link
Owner

@NathanielACollier Any updates on this? :)

@NathanielACollier
Copy link
Author

I haven't had time to work on it. There are one or two issues that need to be fixed but it's pretty close except for commands being implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants