Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing html_stream to use selectAll instead of select #103

Closed
wants to merge 1 commit into from
Closed

Changing html_stream to use selectAll instead of select #103

wants to merge 1 commit into from

Conversation

Firexion
Copy link

Changing solution and example to use trumpet's selectAll instead of select, as the problem text says to convert ALL the inner html.

@Firexion
Changing solution and example to use trumpets selectAll instead of se…
5250aa0 
…lect, as the problem text says to convert ALL the inner html.
@Firexion Firexion mentioned this pull request Jan 12, 2015
Closed
@calvinmetcalf
Copy link
Collaborator

the selectAll method is quite a bit more complex, what if we just remove the word all from the problem statement?

@kalinchernev kalinchernev mentioned this pull request Nov 10, 2016
Closed
@kalinchernev
Copy link
Member

Similar to #69, hopefully can work together with #146 to have consolidated solution.

@ccarruitero
Copy link
Contributor

Thanks @Firexion for your PR. Sorry for the delay in review.

I'm closing this, since we are planing to remove trumpet dependency (#239) now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
suggestion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Firexion @calvinmetcalf @kalinchernev @ccarruitero