Completion provider #155
Draft
Completion provider #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have blueprint-compiler as a module that we can use. It also fixes the issue of blueprint-compiler not working in Workbench when built under vscode-flatpak.
sonnyp
force-pushed
the
main
branch
3 times, most recently
from
05f69f1
to
55e450f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Functionality that is static and performance sensitive can be moved here as necessary, but more importantly it can be used to work around problems with introspection in GJS.
|
Currently facing this issue
It looks like it is left in an incorrect state. Screencast.from.2023-08-20.11-04-25.webm |
andyholmes
reviewed
Aug 24, 2023
| Object.assign(this, completion_proposal); | ||
| } | ||
|
|
||
| get_typed_text() { |
There was a problem hiding this comment.
Suggested change
| get_typed_text() { | |
| vfunc_get_typed_text() { |
| #onCompletionRequest = (provider, request) => { | ||
| console.log(`completion-request: ${request.context.get_word()}`); | ||
|
|
||
| const [, start, end] = request.context.get_bounds(); |
There was a problem hiding this comment.
Suggested change
| const [, start, end] = request.context.get_bounds(); | |
| const [success, start, end] = request.context.get_bounds(); | |
| if (!success) { | |
| request.state_changed(Workbench.RequestState.CANCELLED); | |
| return; | |
| } |
Comment on lines
+30
to
+35
| context | ||
| .get_view() | ||
| .push_snippet( | ||
| Source.Snippet.new_parsed(proposal.get_typed_text()), | ||
| null, | ||
| ); |
There was a problem hiding this comment.
Suggested change
| context | |
| .get_view() | |
| .push_snippet( | |
| Source.Snippet.new_parsed(proposal.get_typed_text()), | |
| null, | |
| ); | |
| context.get_buffer().begin_user_action(); | |
| const [success, start, end] = context.get_bounds(); | |
| if (success) context.get_buffer().delete(start, end); | |
| context | |
| .get_view() | |
| .push_snippet( | |
| Source.Snippet.new_parsed(proposal.get_typed_text()), | |
| null, | |
| ); | |
| context.get_buffer().end_user_action(); |
| }) | ||
| .catch(logError) | ||
| .finally(() => { | ||
| request.state_changed(Workbench.RequestState.COMPLETE); |
There was a problem hiding this comment.
I'm honestly not sure what's going wrong, since I'm not familiar with GtkSource. I noticed the finally() handler is not getting called very often though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257
EDIT: the following is outdated thanks to #371
This is blocked by https://gitlab.gnome.org/GNOME/gjs/-/issues/72
https://gitlab.gnome.org/GNOME/gjs/-/issues/255 is a better explanation of the problem