Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 24.8 release finalization #23187

Merged
merged 31 commits into from May 10, 2024
Merged

Merge 24.8 release finalization #23187

merged 31 commits into from May 10, 2024

Conversation

wpmobilebot
Copy link
Contributor

No description provided.

@wpmobilebot wpmobilebot added this to the 24.9 milestone May 10, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR has the Releases label: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor Author

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23187-e7a325a
Version24.8
Bundle IDorg.wordpress.alpha
Commite7a325a
App Center BuildWPiOS - One-Offs #9868
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor Author

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23187-e7a325a
Version24.8
Bundle IDcom.jetpack.alpha
Commite7a325a
App Center Buildjetpack-installable-builds #8916
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dvdchr
Copy link
Contributor

dvdchr commented May 10, 2024

Failed UI tests:

testCreateBlankPage() in PageTests
XCTAssertTrue failed (.../wordpress-ios/WordPress/UITestsFoundation/Screens/MySiteScreen.swift#EndingLineNumber=271&StartingLineNumber=271)

This one is known to be flaky. Retrying...

@dvdchr
Copy link
Contributor

dvdchr commented May 10, 2024

Succeeded after a couple of retries. Looks like we'll need to revisit testCreateBlankPage() again...

Anyhow, I'll go ahead and admin-merge this as part of the release process. 🙂

@dvdchr dvdchr merged commit 6a36818 into trunk May 10, 2024
26 of 27 checks passed
@dvdchr dvdchr deleted the release/24.8 branch May 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants