New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Update when the results controller is reset for tags feed #23179
Conversation
tableViewHandler?.tableView.layoutIfNeeded() | ||
|
||
if !isEmpty { | ||
tableViewHandler?.tableView.scrollToRow(at: IndexPath(row: 0, section: 0), at: .top, animated: false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to use scrollToRow
here because using setContentOffset
would scroll too high sometimes above the first card. I believe this was due to the pull-to-refresh.
馃摬 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
馃摬 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and verified that the race condition no longer happens in the 'Your Tags' stream. I've also tested this with a self-hosted site without Jetpack connection (where the issue was happening more often before this fix.)
Looking good!
Description
Fixes selecting a filter on the "Your Tags" feed. There was a race condition with recreating the results controller which caused unexpected behavior. This moves the recreation of that controller to when the
setContent
is called.Testing
To test:
X
to remove the filterRegression Notes
Potential unintended areas of impact
Subscriptions feed filtering
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: