Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Mode: Fix incorrect predicates used when syncPublishing is off #23176

Merged
merged 2 commits into from May 9, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented May 8, 2024

The app was using a feature flag incorrectly.
It was the case even before RemoteFeatureFlag.syncPublishing was removed.

To test:

  • Test the list presentation with a FF on and off

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.8 ❄️ milestone May 8, 2024
@kean kean requested a review from momo-ozawa May 8, 2024 21:37
@kean kean changed the base branch from trunk to release/24.8 May 8, 2024 21:37
@dangermattic
Copy link
Collaborator

dangermattic commented May 8, 2024

1 Warning
⚠️ This PR is assigned to the milestone 24.8 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 8, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23176-2178db3
Version24.8
Bundle IDorg.wordpress.alpha
Commit2178db3
App Center BuildWPiOS - One-Offs #9847
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 8, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23176-2178db3
Version24.8
Bundle IDcom.jetpack.alpha
Commit2178db3
App Center Buildjetpack-installable-builds #8895
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit df9aaee into release/24.8 May 9, 2024
24 checks passed
@kean kean deleted the fix/incorrect-predicates-used-in-post-list branch May 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants