[Notifications Refresh] Present Comment Moderations Options View

[salimbraksa]

Fixes https://github.com/Automattic/wordpress-mobile/issues/38

Description

This pull request adds logic where tapping the 'Change Status' button in the header menu brings up the Comment Moderation Options view.

iPhone	iPad

Test Instructions

1. Run Jetpack and login.
2. Navigate to "Notifications" screen.
3. Select a "Comment" notification.
4. Tap the more menu.
5. Tap "Change Status" button.
6. Expect the Comment Moderation Options sheet to appear.
7. Select any option.
   • The status is updated but I didn't bother to update the outdated comment status moderation view since it will be removed.
8. Go back to the previous screen.
9. Tap the same comment notification.
10. Verify the outdated comment moderation UI is updated.

Regression Notes

1. Potential unintended areas of impact
   N/A

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N/A

3. What automated tests I added (or what prevented me from doing so)
   N/A

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23175-346b52c
	Version	24.8
	Bundle ID	org.wordpress.alpha
	Commit	346b52c
	App Center Build	WPiOS - One-Offs #9845

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[salimbraksa]

This logic was extracted from CompliancePopoverViewController. I was going to implement the same class for the Comment Moderations Options View but then I thought why not implement a reusable component instead.

I'll open a separate PR to refactor the CompliancePopoverViewController to use this class.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23175-346b52c
	Version	24.8
	Bundle ID	com.jetpack.alpha
	Commit	346b52c
	App Center Build	jetpack-installable-builds #8893

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[salimbraksa]

This code adjusts the layout of the bottom sheet when fonts are enlarged. I needed a way to update the parent view in response to changes in the child view's size. While I don't like this approach of accessing DrawerPresentationController due to it making too many assumptions about implementation details, it is the best approach I could think of.

[alpavanoglu]

Do we need to handle the else path here? I think it is fine as long as it works with other VC types. Otherwise, it would make sense to specify the type rather than make it look like it is more flexible.

[alpavanoglu]

If that's the presenting view controller, you can use unowned here and maybe specify the VCType rather than using UIViewController since the name already specifies it.

[salimbraksa]

That's the bottom sheet view controller being presented. I need to keep a reference to this view controller so I can dismiss it later when the user selects a status. The reference is optional because the view controller might not always be present.

While now it's possible to have optional unowned references:

private unowned var changeStatusViewController: BottomSheetViewController?

Unlike with weak, the reference won't automatically turn nil if the object is deallocated. Accessing a deallocated object will cause the app to crash.

I need the object to automatically turn nil when the view controller is deallocated ( aka dismissed ).

[salimbraksa]

maybe specify the VCType rather than using UIViewController since the name already specifies it.

Resolved in 346b52c

[alpavanoglu]

Do we need to handle the else path here? I think it is fine as long as it works with other VC types. Otherwise, it would make sense to specify the type rather than make it look like it is more flexible.

[alpavanoglu]

AC is satisfied. All actions work as expected.