Offline Mode: Deduplicate new posts

[momo-ozawa]

Fixes pe7hp4-N2-p2#comment-328

Description

• Fixes duplicate posts from appearing in the posts list when refresh and sync (upon regaining connectivity) happens in parallel, by sending a UUID as a foreign key in the metadata

How to test

Precondition: set a response breakpoint on https://public-api.wordpress.com/rest/v1.2/sites/*/posts/new?context=edit&locale=en

• Create and save a new draft
• Hit the breakpoint
• ✅ Verify the foreignID is sent
• Pull to refresh
• ✅ Verify that duplicate posts don't appear when refresh and sync (upon regaining connectivity) happens in parallel
• Release the breakpoint

Screen.Recording.2024-05-09.at.11.05.44.mov

Regression Notes

1. Potential unintended areas of impact
   n/a

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   n/a

3. What automated tests I added (or what prevented me from doing so)
   n/a

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[dangermattic]

	2 Warnings
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	This PR is assigned to the milestone 24.8 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23173-9a2fb24
	Version	24.8
	Bundle ID	org.wordpress.alpha
	Commit	9a2fb24
	App Center Build	WPiOS - One-Offs #9858

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23173-9a2fb24
	Version	24.8
	Bundle ID	com.jetpack.alpha
	Commit	9a2fb24
	App Center Build	jetpack-installable-builds #8906

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[momo-ozawa]

Hi @kean, can I get a re-review?

Here's a video of setting a breakpoint on the posts/new response, then refreshing the list. It now works as expected.

Screen.Recording.2024-05-09.at.11.05.44.mov

[kean]

Hey, works as expected, but I left two more small comments.

[momo-ozawa]

Thanks @kean - I've addressed your comments 🙇‍♀️

[kean]

Tested:

• Posts, self-hosted - 🟢
• Posts, wp.com - 🟢
• Pages - 🔴

The deduplication doesn't work for pages because the app doesn't send the metadata in that case, which is a production behavior. I think it might be worth fixing it separately (and in trunk?).