Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Subscribers: Dynamic type support improvements #23141

Merged

Conversation

staskus
Copy link
Contributor

@staskus staskus commented May 2, 2024

Fixes #23060

Make dynamic type improvements for Stats cells used in Subscribers tab. In most cases, I just limit the maximum content size category so the labels would grow to the appropriate size without breaking layout.

To test:

  1. Open Stats -> Subscribers
  2. Increase/decrease dynamic type font size
  3. Confirm that layout grows up until the point the UI is not broken

Regression Notes

  1. Potential unintended areas of impact

Shouldn't be any

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

  2. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23141-409a687
Version24.8
Bundle IDorg.wordpress.alpha
Commit409a687
App Center BuildWPiOS - One-Offs #9766
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23141-409a687
Version24.8
Bundle IDcom.jetpack.alpha
Commit409a687
App Center Buildjetpack-installable-builds #8812
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that text is limited to about 200% and beyond that doesn't increase 👍

@staskus staskus merged commit 2c4e883 into trunk May 3, 2024
24 of 29 checks passed
@staskus staskus deleted the task/23060-stats-subscribers-dynamic-type-support-improvements branch May 3, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats Subscribers: Dynamic type support improvements
3 participants