New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Add a footer view for the Reader tags feed #23109
Conversation
馃摬 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
馃摬 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described. LGTM
I couldn't find a good way to fix this because it appears the inUse property is currently used. I'll keep attempting to look for a solution.
Yeah, I'm not sure yet what inUse
is used for, but I feel like for the new Tags stream we should improve it later by creating a new view controller that's not driven by NSFetchedResultsController
. We just need to fetch the tags once every time the stream is loaded or the user initiates a refresh gesture.
Maybe at some point we can rewrite the stream view controller. There's a decent amount of strange behavior from the current one, which is very difficult to fix or track down.
We'd still need to handle a user's tags changing, unless navigating back counts as loading. They can open one of the tag posts, then tap on a tag for that post, and follow it. Thanks for the review! |
Fixes #23108
Description
Adds the "More" footer view to the Reader tags feed.
Note: There's an existing issue when navigating to a tag feed from the "Your Tags" feed. This is due to the following chain of events:
readerTopic
of the stream view controller gets setdidSet
of thereaderTopic
sets theinUse
property on the tag managed object and the context is savedThis causes the collection view offset to briefly show at the beginning, and then it'll update back to the end of the content when navigating back to the "Your Tags" feed from the tag feed.
I couldn't find a good way to fix this because it appears the
inUse
property is currently used. I'll keep attempting to look for a solution.Screenshots
Testing
To test:
Regression Notes
Potential unintended areas of impact
Should be none.
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: