New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications P2] Comment Moderation View #23090
Merged
alpavanoglu
merged 4 commits into
feature/notifications_refresh_p2
from
feature/notifications-p2_comment-moderation-sheet
Apr 30, 2024
Merged
[Notifications P2] Comment Moderation View #23090
alpavanoglu
merged 4 commits into
feature/notifications_refresh_p2
from
feature/notifications-p2_comment-moderation-sheet
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
Hi @alpavanoglu 👋 , I'm bumping this PR's milestone to |
salimbraksa
reviewed
Apr 29, 2024
...ress/Classes/ViewRelated/Notifications/Comment Moderation/CommentModerationOptionsView.swift
Show resolved
Hide resolved
salimbraksa
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
alpavanoglu
merged commit Apr 30, 2024
6aba19f
into
feature/notifications_refresh_p2
25 of 26 checks passed
alpavanoglu
deleted the
feature/notifications-p2_comment-moderation-sheet
branch
April 30, 2024 16:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #https://github.com/Automattic/wordpress-mobile/issues/33
Description
This PR adds the UI for comment moderation options sheet.
Testing Steps
Go to
CommentModerationOptionsView
file in Xcode and enable Previews.OR
Present the view in the app.
Compare against the designs here: yWt5gg3nWORhu079Qfv3mS-fi-1453_5937
Screenshot Reference
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: