Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications P2] Comment Moderation View #23090

Conversation

alpavanoglu
Copy link
Contributor

@alpavanoglu alpavanoglu commented Apr 25, 2024

Refs #https://github.com/Automattic/wordpress-mobile/issues/33

Description

This PR adds the UI for comment moderation options sheet.

Testing Steps

Go to CommentModerationOptionsView file in Xcode and enable Previews.
OR
Present the view in the app.

Compare against the designs here: yWt5gg3nWORhu079Qfv3mS-fi-1453_5937

Screenshot Reference

Light Mode Dark Mode
Screenshot 2024-04-29 at 12 13 13 Screenshot 2024-04-29 at 12 18 29

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 25, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23090-9ccbdce
Version24.7
Bundle IDcom.jetpack.alpha
Commit9ccbdce
App Center Buildjetpack-installable-builds #8784
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 25, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23090-9ccbdce
Version24.7
Bundle IDorg.wordpress.alpha
Commit9ccbdce
App Center BuildWPiOS - One-Offs #9739
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dvdchr
Copy link
Contributor

dvdchr commented Apr 29, 2024

Hi @alpavanoglu 👋 , I'm bumping this PR's milestone to 24.9 since I'm starting code freeze. Feel free to re-target this to the release branch if this is a blocker or intended for 24.8.

@dvdchr dvdchr modified the milestones: 24.8, 24.9 Apr 29, 2024
Copy link
Contributor

@salimbraksa salimbraksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@alpavanoglu alpavanoglu merged commit 6aba19f into feature/notifications_refresh_p2 Apr 30, 2024
25 of 26 checks passed
@alpavanoglu alpavanoglu deleted the feature/notifications-p2_comment-moderation-sheet branch April 30, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants