Stats: Open People -> Subscribers from Subscribers List card
#23077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23077-83df7d6 | |
| Version | 24.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 83df7d6 | |
| App Center Build | WPiOS - One-Offs #9705 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23077-83df7d6 | |
| Version | 24.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 83df7d6 | |
| App Center Build | jetpack-installable-builds #8749 |
staskus
force-pushed
the
task/23046-subscribers-list-card
branch
from
cc88ba4
to
579498e
Compare
guarani
approved these changes
Apr 26, 2024
| @@ -497,8 +503,9 @@ private extension PeopleViewController { | |||
| filterBar.items = filtersAvailableForBlog(blog) | |||
| filterBar.addTarget(self, action: #selector(selectedFilterDidChange(_:)), for: .valueChanged) | |||
|
|
|||
| // By default, let's display the Blog's Users | |||
| filter = .users | |||
| let indexToSet = Filter.allCases.firstIndex(where: { $0 == defaultFilter }) ?? 0 | |||
There was a problem hiding this comment.
nitpick:
Suggested change
| let indexToSet = Filter.allCases.firstIndex(where: { $0 == defaultFilter }) ?? 0 | |
| let indexToSet = Filter.allCases.firstIndex(of: defaultFilter) ?? 0 |
Also, I think a force unwrap is OK since we know that defaultFilter is present in allCases.
| @@ -28,13 +28,13 @@ final class PersonViewController: UITableViewController { | |||
| var title: String { | |||
| switch self { | |||
| case .User: | |||
| return NSLocalizedString("Blog's User", comment: "Blog's User Profile. Displayed when the name is empty!") | |||
| return NSLocalizedString("user.details.title.user", value: "Site's User", comment: "Sites's User Profile. Displayed when the name is empty!") | |||
There was a problem hiding this comment.
Good idea to use "Site" instead 👍
|
Just noting here that the People screen doesn't load for non-Admins (more info in https://a8c.slack.com/archives/C06BR07TJHK/p1714164554910319) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #23046
Continuation of Subscribers List Card PR (#23067)
Open
People -> SubscribersfromSubscribers Listcard withSubscriberstab selected.Other remaining tasks in other PRs:
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: