Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gutenberg block processors performance to avoid long delay when saving a post #22845

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 18, 2024

Fixes wordpress-mobile/gutenberg-mobile#6696.

Note

Uses the changes from #22886.

[Add Benchmark]

To test

Follow the testing instructions to cover the functionality related to the processors for each block:

Regression Notes

  1. Potential unintended areas of impact
    The block processors are only used when saving a post. No other area should be impacted.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested saving a post with different blocks. Additionally, each processor has its own unit test that has been verified.

  3. What automated tests I added (or what prevented me from doing so)
    Some unit tests have been added to cover the content parsing.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@fluiddot fluiddot added [Type] Bug Gutenberg Editing and display of Gutenberg blocks. labels Mar 18, 2024
@fluiddot fluiddot added this to the 24.6 milestone Mar 18, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 18, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22845-5547592
Version24.5
Bundle IDorg.wordpress.alpha
Commit5547592
App Center BuildWPiOS - One-Offs #9232
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 18, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22845-5547592
Version24.5
Bundle IDcom.jetpack.alpha
Commit5547592
App Center Buildjetpack-installable-builds #8277
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@fluiddot fluiddot force-pushed the update/improve-gutenberg-block-procesors branch from 7f9e423 to 5547592 Compare March 21, 2024 18:27
@fluiddot fluiddot changed the base branch from trunk to add/gutenberg-content-parsing March 21, 2024 18:28
@fluiddot
Copy link
Contributor Author

I'm considering splitting this PR into smaller PRs, one for each block processor.

@fluiddot
Copy link
Contributor Author

I'm considering splitting this PR into smaller PRs, one for each block processor.

Closing in favor of new PRs.

@fluiddot fluiddot closed this Mar 26, 2024
@fluiddot fluiddot deleted the update/improve-gutenberg-block-procesors branch March 26, 2024 12:09
@fluiddot fluiddot removed this from the 24.6 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long delay when saving a post
3 participants