monero_wallet_light implementation #58
Conversation
|
Should #55 be closed? |
There was a problem hiding this comment.
Just a quick review with some initial thoughts.
monero_wallet_full is essentially a wrapper to wallet2. What do you think of having monero_wallet_light extend monero_wallet_full to avoid the code duplication?
FYI my Element Matrix appears to be having a problem where my messages aren't being received.
src/wallet/monero_wallet_light.cpp
Outdated
| return output; | ||
| } | ||
|
|
||
| std::shared_ptr<monero_light_rates> monero_light_rates::deserialize(const std::string& config_json) { |
There was a problem hiding this comment.
I'm not familiar with the rates in the light wallet. Why have them?
There was a problem hiding this comment.
It could be useful to calculate the balance in local currency, maybe exposing a method like float monero_wallet_light::get_rate(string fiat_code)
There was a problem hiding this comment.
It could be useful to calculate the balance in local currency, maybe exposing a method like
float monero_wallet_light::get_rate(string fiat_code)
Where are the rates coming from, the light wallet server? I ask because typically pricing can be a service on top of a pure native XMR wallet, and not part of the wallet api itself, which would create a dependence on external services.
There was a problem hiding this comment.
The rates object comes from lws server, in particularly in the get_address_info method
Matrix dot org and monero dot social homeservers have issues sending/receiving to/from eachother. Its being looked in to. |
|
@plowsof Any update on the issue sending messages to each other? |
May we can talk on IRC #monero-bounties channel? |
|
I made the changes, I still have to test though |
|
I'm successfully running monero_light_tests on my monero-project fork, branch light_wallet_maintenance |
everoddandeven
force-pushed
the
master
branch
2 times, most recently
from
1ffd98f
to
9e3deb2
Compare
This PR includes monero_wallet_light implementation