Use IDs for tokens #3695
Merged
Use IDs for tokens #3695
+83
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is it better to use IDs? What's the motivation for this change? |
|
Repos can be renamed and multiple users with the same username can exist when using multiple forges. |
I don't think so: https://github.com/woodpecker-ci/woodpecker/blob/main/server/api/hook.go#L191-L207 |
qwerty287
reviewed
May 14, 2024
lafriks
reviewed
May 14, 2024
|
Deployment of preview was torn down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently used user and repo names for tokens. Users will need to login again. Repo hooks don't need to be updated as we never actually check the tokens content, but just use the token as hash.