-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to define which services a step uses and deprecate detached
#3411
base: main
Are you sure you want to change the base?
Conversation
it does not solve the thing detatched was able to and is now supposed to remove :/ I still if following the KISS principe detatched is the best way to do so. yes the proposed feature here would have other benefits through ;) PS: if service is not registered at a single step -> always run; else only if step is also exec ... |
Why? The service is started when the step it needs is started. If you have other steps running before it, the service can use the artifacts of this step. We could also try to extend this by allowing
But this mixes serviced and pipeline steps. You shouldn't be able to define services in the steps section.
No, it should fail, just like |
detached
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3411.surge.sh |
Add a new
uses
that allows to define the services a step uses to not run services the whole time (for now it's similar todetached
).Example
Order/stages:
x
y
, andsome_service
is startedz
TODO:
uses
so they can use other servicesdepends_on
so they can depends on stepscloses #2495