This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix for storybook to ensure all components render #11465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required because storybook build fails because the STORE_PAGES is undefined in that context.
opr
added
status: needs review
tools
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +3.46 kB (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Oct 27, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes Storybook as not all components are rendering there despite the fix added in #11456.
It removes the
babel-loaderwebpack loader that is included in storybook by default, for some reason this isn't parsing our files correctly. I followed the comment here: storybookjs/storybook#3346 (comment)Why
After upgrading to webpack 5 storybook stopped working and in #11456 I added a fix, however some components still didn't show after this. It is due to the
STORE_PAGESitem in theallSettingsobject not being defined in the storybook context.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
npm run storybooklocalhost:6006and check all components load.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog