Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace react-native-svg with ART #12

Merged
merged 5 commits into from May 31, 2017
Merged

replace react-native-svg with ART #12

merged 5 commits into from May 31, 2017

Conversation

koenpunt
Copy link
Contributor

since react-native ships with it's own vector drawing library, why use an external dependency?

This merge request removes react-native-svg as a dependency, and implements the rendering using React Native's ART instead.

since react-native ships with it's own vector drawing library, why use an external dependency?
@wonsikin
Copy link
Owner

You are genius. But I got some problems when I try to run the Example.

Android

In order to run on the android, I have to modify the Example/android/app/src/main/java/com/example/MainApplication.java:

   private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
     @Override
-    protected boolean getUseDeveloperSupport() {
+    public boolean getUseDeveloperSupport() {
       return BuildConfig.DEBUG;
     }

When I try to run example in the latest react native version, I got the error UnableToResolveError: Unable to resolve module AccessibilityInfo

@koenpunt
Copy link
Contributor Author

Let me check, I didn't experience any issues on Android or iOS though.

@koenpunt
Copy link
Contributor Author

Oh but I did only test with the version of react-native being used in the example, but that one is pretty outdated. I could update the example too?

@koenpunt
Copy link
Contributor Author

koenpunt commented May 29, 2017

Works for me on both platforms with the latest React-Native too:

@koenpunt
Copy link
Contributor Author

See my latest commit for an updated Example app

@koenpunt
Copy link
Contributor Author

I've now also removed the barcodes directory from the repository, and added JsBarcode as a dependency to use their encoders directly.

@wonsikin
Copy link
Owner

@koenpunt I do think that you are a genius.I'll check the example, if OK, I will publish this package.

@wonsikin wonsikin merged commit a8ba2b0 into wonsikin:master May 31, 2017
@koenpunt
Copy link
Contributor Author

Great 🚀 I will submit some more patches the upcoming time, particularly one for EAN(13) barcodes, since they now do not render when flat is not set to false. This went wrong also before my changes.

@wonsikin
Copy link
Owner

I'll appreciate your patches!

@koenpunt koenpunt deleted the art branch June 23, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants