Revert "wolfictl: track wolfictl releases instead of building from git HEAD" #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t HEAD" This reverts commit 3b391f5. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3b391f5.
Rationale:
Consistency. All the other tools in the sdk image are built from HEAD and only require cutting a tolls release and updating digests. Contrast that with
wolfictl, which requires cutting a wolfictl release, bumping it in wolfi-dev/os, waiting for the build infrastructure to publish the APK, then cutting a tools release, then updating digests. I didn't realize thatwolfictlhad a different release lifecycle for the sdk image from all the other tools, so I expected some changes to be present in our postsubmit that just weren't, which is leading to a lot of toil.Convenience. See above. It takes a long time to actually land a change to our build infrastructure if we have to roundtrip through wolfi first.
Circular Dependencies. If something is broken with wolfi's builds because there's a bug in
wolfictl, we won't be able to fix it because updating the sdk image requires releasing a newwolfictlAPK, which requires wolfi's build infrastructure to work.