Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSIP use to Renesas RZ support #444

Merged
merged 3 commits into from May 10, 2024
Merged

Conversation

miyazakh
Copy link
Contributor

@miyazakh miyazakh commented Apr 25, 2024

Support Renesas RZ with RSIP driver use

Depending on wolfSSL PR#7474

@miyazakh miyazakh self-assigned this Apr 25, 2024
@miyazakh miyazakh changed the title Add Renesas RZ support to RSIP use Add RSIP use to Renesas RZ support Apr 25, 2024
@miyazakh miyazakh assigned wolfSSL-Bot and unassigned miyazakh Apr 25, 2024
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review feedback. I'd like to setup a build test next as I get time.

@@ -0,0 +1,30 @@
/* Flash_sections.s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flash_wrappedkey_public.s?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is true. Thanks.

@@ -0,0 +1,30 @@
/* Flash_sections.s
*
* Custom configuration for wolfCrypt/wolfSSL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this comment apply?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't. Will remove the line. Thanks.

hal/renesas-rz.c Outdated

err = wolfCrypt_Init();
if (err != 0) {
printf("ERROR: wolfCrypt_Init %d\n", err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check indent. 4 spaces please. Perhaps there are tabs in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Replaced tabs to 4 spaces.

@dgarske dgarske self-assigned this May 8, 2024
@dgarske dgarske self-requested a review May 8, 2024 23:16
@dgarske dgarske merged commit 0ddde6f into wolfSSL:master May 10, 2024
86 checks passed
@miyazakh miyazakh deleted the renesas_rz_rsip branch May 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants