New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RSIP use to Renesas RZ support #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review feedback. I'd like to setup a build test next as I get time.
@@ -0,0 +1,30 @@ | |||
/* Flash_sections.s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flash_wrappedkey_public.s
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is true. Thanks.
@@ -0,0 +1,30 @@ | |||
/* Flash_sections.s | |||
* | |||
* Custom configuration for wolfCrypt/wolfSSL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this comment apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it doesn't. Will remove the line. Thanks.
hal/renesas-rz.c
Outdated
|
||
err = wolfCrypt_Init(); | ||
if (err != 0) { | ||
printf("ERROR: wolfCrypt_Init %d\n", err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check indent. 4 spaces please. Perhaps there are tabs in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Replaced tabs to 4 spaces.
Support Renesas RZ with RSIP driver use
Depending on wolfSSL PR#7474