Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependency xregexp to v5 #231

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 27, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
xregexp (source) 4.4.1 -> 5.1.0 age adoption passing confidence

Release Notes

slevithan/xregexp

v5.1.0

Compare Source

  • XRegExp.matchRecursive: Add support for matching with unbalanced delimiters: #​96
  • Upgrade to Unicode 14.0.0: 0f52a62
  • XRegExp.matchRecursive: Make global non-sticky matches with valueNames return an empty array if no matches found: 6e1711e

v5.0.2

Compare Source

  • Fix TypeScript definition for XRegExp.matchChain: #​325
  • Fix XRegExp.escape to handle -, ,, and # in a way that is compatible with ES6 flag u: #​323

v5.0.1

Compare Source

  • Hotfix for broken npm package.
  • Adds docs folder with extensive documentation.

v5.0.0

Compare Source

Breaking Changes

Improvements

Bug Fixes


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jul 27, 2021
@renovate renovate bot requested a review from a team July 27, 2021 11:03
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #231 (fc88a9a) into master (e557e93) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          15       15           
  Lines         542      542           
=======================================
  Hits          541      541           
  Misses          1        1           
Impacted Files Coverage Δ
lib/j2119/line_matcher.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e557e93...fc88a9a. Read the comment docs.

@slevithan
Copy link

Hi! XRegExp v5 has a breaking change described at https://github.com/slevithan/xregexp#named-capture-breaking-change-in-xregexp-5

Specifically, named backreference properties now appear on the result's groups object (following ES2018), rather than directly on the result. To restore the old handling so you don't need to update old code, run the following line after importing XRegExp: XRegExp.uninstall('namespacing').

XRegExp 4.1.0 and later allow introducing the new behavior without upgrading to XRegExp 5 by running XRegExp.install('namespacing').

Following is the most commonly needed change to update code for the new behavior:

// Change this
const name = XRegExp.exec(str, regexWithNamedCapture).name;

// To this
const name = XRegExp.exec(str, regexWithNamedCapture).groups.name;

Let me know if you have any questions and I'll be happy to help!

@meenahoda meenahoda requested review from meenahoda and removed request for a team August 5, 2021 06:27
@meenahoda meenahoda merged commit 2f77e4a into master Aug 5, 2021
@meenahoda meenahoda deleted the renovate/xregexp-5.x branch August 5, 2021 07:22
@wmfs-bot
Copy link
Contributor

wmfs-bot commented Aug 5, 2021

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@meenahoda
Copy link
Member

Hi @slevithan

That works great! Thank you very much for pointing us towards this and explaining the change 😄

Thanks,
Meena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants