Remove margins for cover page to fix #3635

src/lib/pdfconverter.cc

@@ -1002,10 +1002,31 @@ void PdfConverterPrivate::printDocument() {
 	progressString = "Preparing";
 	emit out.progressChanged(0);
 
+	qreal leftMargin, topMargin, rightMargin, bottomMargin;
+	printer->getPageMargins(&leftMargin, &topMargin, &rightMargin, &bottomMargin, settings.margin.left.second);
+
 	for (int cc_=0; cc_ < cc; ++cc_) {
 		pageNumber=1;
 		for (int d=0; d < objects.size(); ++d) {
+			if (objects[d].settings.isCover) {
+				painter->save();
+				painter->translate(-leftMargin * printer->width() / printer->widthMM(), -topMargin * printer->height() / printer->heightMM());
+				printer->setPageMargins(0, 0, 0, 0, settings.margin.left.second);
+				if (objects[d].web_printer != 0) {
+					/*
+					 * delete objects[d].web_printer here, then in beginPrintObject(objects[d]) will re-create
+					 * a new web_printer to use printer as we changed page margins for cover page.
+					 * otherwise, the change setPageMargins to 0 will not works.
+					 */
+					delete objects[d].web_printer;
+					objects[d].web_printer = 0;
+				}
+			}
 			beginPrintObject(objects[d]);
+			if (objects[d].settings.isCover) {
+				printer->setPageMargins(leftMargin, topMargin, rightMargin, bottomMargin, settings.margin.left.second);
+				painter->restore();
+			}
 			// XXX: In some cases nothing gets loaded at all,
 			//      so we would get no webPrinter instance.
 			int pageCount = objects[d].web_printer != 0 ? objects[d].web_printer->pageCount() : 0;

src/lib/pdfsettings.cc

@@ -162,6 +162,7 @@ struct DLL_LOCAL ReflectImpl<PdfObject>: public ReflectClass {
 		WKHTMLTOPDF_REFLECT(includeInOutline);
 		WKHTMLTOPDF_REFLECT(pagesCount);
 		WKHTMLTOPDF_REFLECT(isTableOfContent);
+		WKHTMLTOPDF_REFLECT(isCover);
 		WKHTMLTOPDF_REFLECT(tocXsl);
 	}
 };
@@ -405,6 +406,7 @@ PdfObject::PdfObject():
 	includeInOutline(true),
 	pagesCount(true),
 	isTableOfContent(false),
+	isCover(false),
 	tocXsl("") {};
 
 QString PdfGlobal::get(const char * name) {

src/lib/pdfsettings.hh

@@ -202,6 +202,8 @@ struct DLL_PUBLIC PdfObject {
 
 	bool isTableOfContent;
 
+	bool isCover;
+
 	QString tocXsl;
 
 	QString get(const char * name);

src/pdf/pdfcommandlineparser.cc

@@ -178,6 +178,7 @@ void PdfCommandLineParser::parseArguments(int argc, const char ** argv, bool fro
 			ps.header.line = ps.footer.line = false;
 			ps.header.htmlUrl = ps.footer.htmlUrl = "";
 			ps.includeInOutline = false;
+			ps.isCover = true;
 
 			continue;
 		} else if (!strcmp(argv[arg],"toc")) {