This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Update createRequest warning message to indicate a possible solution #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
add-suggestion-in-warning-message
branch
from
861aea7
to
4f507a4
Compare
This change updates the `createRequest` signal on a `disposed` `NetworkAccessManager` warning message to indicate one more issue that may be fixed by a user controlled setting. This was discovered by running with `--log-level debug` which I added in b8f9f5e / wkhtmltopdf#4668 and seeing the debug message "Loading done; Stopping QWebPage and any possible page refreshes." before I expected it to be called (before an API request had finished). This is called by the `loadFinished` handler https://github.com/wkhtmltopdf/wkhtmltopdf/blob/5b26acc41d8209d3b4c4018ac7350b8cea64fa73/src/lib/multipageloader.cc#L336-L340 and from that I realized that `loadDone` was being called too early. I don't believe the immediate `loadDone()` is being called because the default JavaScript delay is 200ms, but setting the timeout to 5 seconds fixed the issue for me, and logging this suggestion as a warning may help someone else when debugging.
terencehonles
force-pushed
the
add-suggestion-in-warning-message
branch
from
4f507a4
to
d5d4a31
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
createRequestsignal on adisposedNetworkAccessManagerwarning message to indicate one more issue that may be fixed by a user controlled setting. This was discovered by running with--log-level debugwhich I added in b8f9f5e / #4668 and seeing the debug message "Loading done; Stopping QWebPage and any possible page refreshes." before I expected it to be called (before an API request hadfinished). This is called by the
loadFinishedhandlerwkhtmltopdf/src/lib/multipageloader.cc
Lines 336 to 340 in 5b26acc
loadDonewas being called too early. I don't believe the immediateloadDone()is being called because the default JavaScript delay is 200ms, but setting the timeout to a larger value fixed the issue for me, and logging this suggestion as a warning may help someone else when debugging.