This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Fix warnings #5075
Open
Fix warnings #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2021 23:23
fix possible null pointer dereference make contrustor variable initialization order correspond to variable order use constant begin/end functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, while trying to build project i found several warnings, some of them C++ related, other Qt.
I tried to fix few of them, all fixes seem very small and should not affect real code.
First one is to avoid possible null pointer dereference, that will never happen in real life, since function always receives variable... well at least compiler is happier this way.
Another is about using const interator instead of non-const.
Few of them concern Qt functions deprecation.
Another one is about making connect() function receive options in normalized form.