This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Fix bug #4460 #5031
Open
Fix bug #4460 #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich in turn generates ProtocolUnknownError by using a fake denied response instead
MagicalTux
force-pushed
the
fix-4460-blocked-case
branch
from
136ce55
to
e6ea11e
Compare
ashkulz
approved these changes
Jun 29, 2021
|
Looks like there are build failures as well, @MagicalTux? |
|
@MagicalTux is there any movement on this? We just ran into this bug and are keen to see this fix get merged! |
ashkulz
approved these changes
Jan 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4460 is linked to the fact that when a url is blocked, the code will instead attempt to access about:blank, which is not a protocol supported by QNetworkAccessManager.
Instead, this will return a fake QNetworkReply with a status code of 403 that should take care of any unauthorized access in a clean and Qt friendly way.