This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Make internal linking more adhere to HTML spec. #4412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, and most importantly the analysis! |
allenwu1973
force-pushed
the
master
branch
3 times, most recently
from
2606e03
to
b8640ef
Compare
|
@ashkulz I've implemented CSS.escape in utilities.cc as escapeCSS. I'm not sure about the naming and where to put it. Thanks! |
see wkhtmltopdf#4406 * Support lookup through decoded url fragement * Escape special characters when building query selector
|
I merged this PR to my fork and rebuilt wkhtmltox. It seems links with question marks are still not handled properly, so this PR may not be a complete solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR fixes #4406.
I'm really unfamiler with C++ and qt, hope I didn't screw up too much ;)