-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExpandableOverlay testkit driver #2917
base: master
Are you sure you want to change the base?
Conversation
import {type ComponentProps, useComponentDriver} from '../../testkit/new/Component.driver'; | ||
import {usePressableDriver} from '../../testkit/new/usePressable.driver'; | ||
|
||
type OverlayDriverType<Props extends ExpandableOverlayProps> = Props extends {useDialog: true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the types
testID: `${testID}.overlay` | ||
}) as OverlayDriverType<Props>; | ||
|
||
const getOverlay = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably return isVisible
and not the implementation detials
driver.press(); | ||
expect(driver.getOverlay().getModal().isVisible()).toBeTruthy(); | ||
}); | ||
const universe = 'Hello Universe'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not put this at the top of the file?
Description
Testkit driver for the ExpandableOverlay.
Changelog
None
Additional info
None