Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redo rn 73 support #7864

Merged
merged 9 commits into from
Apr 7, 2024
Merged

feat: redo rn 73 support #7864

merged 9 commits into from
Apr 7, 2024

Conversation

gosha212
Copy link
Contributor

No description provided.

@gosha212 gosha212 linked an issue Mar 31, 2024 that may be closed by this pull request
[RN73] Support for Android #7835
Closed
@gosha212 gosha212 requested a review from d4vidi April 2, 2024 11:21
d4vidi
d4vidi reviewed Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It kind of LGTM, but:

  1. Let's double check that it works with apps running RN71
  2. I'm not 100% we'd be able to run the playground using RN < 73, has this always been the approach? Let's work out the policy

.buildkite/pipeline.yml Outdated Show resolved Hide resolved
lib/android/app/build.gradle Show resolved Hide resolved
...c/main/java/com/reactnativenavigation/viewcontrollers/stack/topbar/button/ButtonPresenter.kt Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
playground/android/app/build.gradle Show resolved Hide resolved
playground/ios/scripts/pre-install.js Show resolved Hide resolved
@gosha212 gosha212 merged commit bf6f379 into master Apr 7, 2024
4 checks passed
@firasath-virtus
Copy link

not able to link by command npx rnn-link
my project is with latest version of react native 0.73.6 and android is setup with Kotlin and don't no how to manually link the with .kt file in documentation manual link is only shown for java not of .kt file

@gosha212
Copy link
Contributor Author

not able to link by command npx rnn-link my project is with latest version of react native 0.73.6 and android is setup with Kotlin and don't no how to manually link the with .kt file in documentation manual link is only shown for java not of .kt file

@firasath-virtus
Here a ticket. You are welcome to contribute. We have no capacity for this task in the near future unfortunately.
#7821

@siddarthkay siddarthkay mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4vidi d4vidi d4vidi approved these changes

Assignees
No one assigned
Labels
type: accepted/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RN73] Support for Android
4 participants
@gosha212 @firasath-virtus @d4vidi @wixmobile