bug - Support MainApplication.kt #7846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tourofer
commented
Feb 13, 2024
| @@ -6,8 +6,10 @@ var ignoreFolders = { | |||
| exports.mainActivityJava = glob.sync('**/MainActivity.java', ignoreFolders)[0]; | |||
| exports.mainActivityKotlin = glob.sync('**/MainActivity.kt', ignoreFolders)[0]; | |||
| var mainApplicationJava = glob.sync('**/MainApplication.java', ignoreFolders)[0]; | |||
| var mainApplicationKotlin = glob.sync('**/MainApplication.kt', ignoreFolders)[0]; | |||
| var mainApplication = mainApplicationJava || mainApplicationKotlin | |||
| exports.mainApplicationJava = mainApplicationJava; | |||
There was a problem hiding this comment.
I left mainApplicationJava, as i'm not sure if we do want to change this variable. please change it as well if it's needed
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
crherman7
reviewed
Apr 29, 2024
| @@ -6,8 +6,10 @@ var ignoreFolders = { | |||
| exports.mainActivityJava = glob.sync('**/MainActivity.java', ignoreFolders)[0]; | |||
There was a problem hiding this comment.
probably want to handle MainActivity.{java,kt} the same as we treat AppDelegate.{m,mm}
| @@ -6,8 +6,10 @@ var ignoreFolders = { | |||
| exports.mainActivityJava = glob.sync('**/MainActivity.java', ignoreFolders)[0]; | |||
| exports.mainActivityKotlin = glob.sync('**/MainActivity.kt', ignoreFolders)[0]; | |||
| var mainApplicationJava = glob.sync('**/MainApplication.java', ignoreFolders)[0]; | |||
| var mainApplicationKotlin = glob.sync('**/MainApplication.kt', ignoreFolders)[0]; | |||
There was a problem hiding this comment.
probably want to handle MainApplication.{java,kt} the same as we treat AppDelegate.{m,mm}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.