Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kotlin build issues with react native 73.x #7831

Closed
wants to merge 4 commits into from
Closed

Fix kotlin build issues with react native 73.x #7831

wants to merge 4 commits into from

Commits on Mar 21, 2024

  1. chore: use JavaVersion 17 instead of jdk 1.8

    @siddarthkay
    siddarthkay committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    bd35b2e View commit details
    Browse the repository at this point in the history

  2. fix: kotlin type mismatch 

    Otherwise we get errors like this :

```
e: file:///private/tmp/nix-build-status-mobile-build-nightly-android.drv-1/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/topbar/button/ButtonPresenter.kt:196:21 'onInitializeAccessibilityNodeInfo' overrides nothing
e: file:///private/tmp/nix-build-status-mobile-build-nightly-android.drv-1/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/topbar/button/ButtonPresenter.kt:200:65 Type mismatch: inferred type is View? but View was expected
e: file:///private/tmp/nix-build-status-mobile-build-nightly-android.drv-1/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/topbar/button/ButtonPresenter.kt:200:71 Type mismatch: inferred type is AccessibilityNodeInfoCompat? but AccessibilityNodeInfoCompat was expected
```
    @siddarthkay
    siddarthkay committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b5542b5 View commit details
    Browse the repository at this point in the history

  3. chore: bump robolectric & mockito 

    These upgrades are needed to deal get playground app to work with java 17
    @siddarthkay
    siddarthkay committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b8e666a View commit details
    Browse the repository at this point in the history

  4. temporarily skip the failing test

    @siddarthkay
    siddarthkay committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    6d1315b View commit details
    Browse the repository at this point in the history