Upgrade react-native to 0.71.8 #7717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudoPlz
reviewed
May 22, 2023
There was a problem hiding this comment.
this is shaping up, but we're actually duplicating work here, I also made those changes on another branch.
That's totally fine though since you were faster than me.
Btw, I left 1 comment down there (a question) and reviewed the rest of the PR.
This looks good.
SudoPlz
requested changes
May 23, 2023
There was a problem hiding this comment.
this is looking sharp.
A couple of comments in there.
Also, we may need to add a playground/Gemfile file, with the following content:
source 'https://rubygems.org'
# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version
ruby '>= 2.6.10'
gem 'cocoapods', '>= 1.11.3'
| } | ||
|
|
||
|
|
||
| def jscFlavor = 'org.webkit:android-jsc:+' | ||
|
|
||
| android { | ||
| compileSdkVersion rootProject.ext.get("compileSdkVersion") |
There was a problem hiding this comment.
consider adding a namespace here, like so:
namespace "com.reactnativenavigation.playgroun and remove package="com.reactnativenavigation.playground" from AndroidManifest.xml for the package name.
This was referenced May 23, 2023
Closed
Co-authored-by: Ioannis Kokkinidis <sudoplz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.