Fix truncated topBar title component on RN0.71 #7716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yogevbd
commented
May 22, 2023
•
yogevbd
commented
…avigation into fixComponentTitleRN71
…avigation into fixComponentTitleRN71
…avigation into fixComponentTitleRN71
…avigation into fixComponentTitleRN71
yogevbd
changed the title
SudoPlz
pushed a commit
that referenced
this pull request
May 30, 2023
* Fix title component layout on RN71 * Update package.json version to 7.33.0-alpha.1 [buildkite skip] * Fix TitleBarReactView flavor * Update package.json version to 7.33.0-alpha.2 [buildkite skip] * f * f * Update package.json version to 7.33.0-alpha.3 [buildkite skip] * Remove unnecessary cast to ViewGroup (#7706) * Update package.json version to 7.33.0-alpha.4 [buildkite skip] * Fix condition for rootview having no children (#7707) * Update package.json version to 7.33.0-alpha.5 [buildkite skip] * Fix component title crash * verify rootView has children * Update package.json version to 7.33.0-alpha.6 [buildkite skip] * Update package.json version to 7.33.0-alpha.7 [buildkite skip] * A fix (possible) of title bar width issue. * A fix (second attempt) of title bar width issue. * A fix (second attempt) of title bar width issue. * We need a dirty trick only in debug mode. * Update package.json version to 7.33.0-alpha.8 [buildkite skip] * Fixed TitleBarReactView.kt. * Fix YellowBox delegate on RN71 * Remove unneeded YellowBoxDelegate.kt * Update package.json version to 7.33.0-alpha.9 [buildkite skip] * Fix TitleBarReactView.kt * Update package.json version to 7.33.0-alpha.10 [buildkite skip] * Update package.json version to 7.33.0-alpha.11 [buildkite skip] --------- Co-authored-by: wixmobile <mobile1@wix.com> Co-authored-by: Yedidya Kennard <yedidyak@wix.com> Co-authored-by: Evgeni Silman <evgenis@wix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.