Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom tab Badge style #6973

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Bottom tab Badge style #6973

wants to merge 15 commits into from

Conversation

swabbass
Copy link
Contributor

@swabbass swabbass commented Feb 18, 2021

Changes:

Old way (deprecated):

  Navigation.mergeOptions(this.props.componentId, {
      bottomTab: {
        badgeColor: 'red',
        badge: 'hello',
      },
    });

New way:

  Navigation.mergeOptions(this.props.componentId, {
      bottomTab: {
        badge: {
          text: 'content',
          textColor: 'green',
          backgroundColor: 'blue',
        },
      },
    });

Demo

Screen.Recording.2021-02-18.at.4.52.53.mov

@lindesvard
Copy link
Contributor

What's the status for this PR? Super excited for it 🚀

@swabbass
Copy link
Contributor Author

What's the status for this PR? Super excited for it 🚀

It is waiting for iOS, implementation, unfortunately, we got a couple of high priority stuff to deal with, but if you want to contribute or know someone who wants to, we will be glad to give you a hand.

@lindesvard
Copy link
Contributor

It is waiting for iOS, implementation, unfortunately, we got a couple of high priority stuff to deal with, but if you want to contribute or know someone who wants to, we will be glad to give you a hand.

Thanks for the fast reply! Understand that you're busy. I'm just glad that you looking at this issue.

Whats left on the iOS side? Because I thought both were done when I glanced at the changed files. Can see if our iOS developer have some time over!

@swabbass
Copy link
Contributor Author

swabbass commented Jul 2, 2021

It is waiting for iOS, implementation, unfortunately, we got a couple of high priority stuff to deal with, but if you want to contribute or know someone who wants to, we will be glad to give you a hand.

Thanks for the fast reply! Understand that you're busy. I'm just glad that you looking at this issue.

Whats left on the iOS side? Because I thought both were done when I glanced at the changed files. Can see if our iOS developer have some time over!

Thanks, :], yeah sure I "wrote" the ios part (as a rookie), it has a small bug and maybe a couple of final touches. The bug is, same js code need to be called twice in order to make badge changes like colour/text..., on ios only, the native side of ios is similar to android though, I'm really sure that experienced ios dev will catch it right away, it might be something I'm missing with the "UI thread" on ios :]

@tyson90
Copy link

tyson90 commented May 13, 2022

@swabbass can you also add badge.fontSize and badge.fontFamily options for more flexible customization?

@xgenem
Copy link

xgenem commented Mar 15, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
React Native Navigation
  
In Progress
Development

Successfully merging this pull request may close these issues.

Add option to change badgeTextColor for bottomTab
5 participants