Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Fix build errors on Xcode 10 #4321

Closed
wants to merge 1 commit into from
Closed

Conversation

rajivshah3
Copy link

This PR deletes the Copy Files step in the Build Phases. It was creating duplicate files which didn't agree well with Xcode's new build system.

Fixes #3608

Tested by successfully building the playground app with Xcode 10.1 on both the new and legacy build systems.

@rajivshah3 rajivshah3 changed the title Fix build errors on Xcode 10 [V2] Fix build errors on Xcode 10 Nov 14, 2018
@henrikra
Copy link
Contributor

Can you explain bit more why those files were copied and why we don't need to copy them anymore? Also would this mean that after this PR is merged the project is not built correctly on Xcode version below 10?

@rajivshah3
Copy link
Author

rajivshah3 commented Nov 14, 2018

why those files were copied

I'm not entirely sure. I'd have to look through the commit history to see why this was added.

why we don't need to copy them anymore?

It seems like they're duplicates. Xcode's new build system seems to treat some things that used to be warnings as errors, so that appears to be the case here. React Native and other projects have recently run into similar issues as well.

Also would this mean that after this PR is merged the project is not built correctly on Xcode version below 10?

No. I've tested it on the new build system (the one that was having problems) as well as the legacy build system (the same one that Xcode 9 uses). It also builds successfully on the CI, which (judging by the logs) appears to be Xcode 9.3 or 9.4 since it's building with the iOS 11.3 SDK.

It looks like something similar was done in #3774 , I'll have to double check why that didn't work

@rajivshah3
Copy link
Author

Fixed in b5d300f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants