Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native 0.73 npx rnn-link doesn't work #7821

Open
1 task done
Tracked by #7834
retyui opened this issue Dec 17, 2023 · 10 comments
Open
1 task done
Tracked by #7834

React Native 0.73 npx rnn-link doesn't work #7821

retyui opened this issue Dec 17, 2023 · 10 comments

Comments

@retyui
Copy link
Contributor

retyui commented Dec 17, 2023

What happened?

starting from rn73 *.java files was convened to *.kt
so auto-linking doesn't work properly

npx rnn-link

/tmp/Rn73/node_modules/react-native-navigation/autolink/postlink/path.js:10
exports.rootGradle = mainApplicationJava.replace(/android\/app\/.*\.java/, 'android/build.gradle');
                                         ^

TypeError: Cannot read properties of undefined (reading 'replace')
    at Object.<anonymous> (/Users/davydnarbutovich/tmp/Rn73/node_modules/react-native-navigation/autolink/postlink/path.js:10:42)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/Users/davydnarbutovich/tmp/Rn73/node_modules/react-native-navigation/autolink/postlink/applicationLinker.js:2:12)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)

What was the expected behaviour?

no js error, *.kt files supported out of the box

Was it tested on latest react-native-navigation?

  • I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

No response

In what environment did this happen?

React Native Navigation version: 7.37.2
React Native version: 0.73
Has Fabric (React Native's new rendering system) enabled: (yes/no)
Node version: 18
Device model:
Android version:

@jtich
Copy link

jtich commented Dec 18, 2023

+1

@JailsonSmidi
Copy link

Mesmo problema

@HaNguyenRN
Copy link

+1

@jtich
Copy link

jtich commented Dec 21, 2023

The issue is that the following line in path.js assumes that mainApplication has the java extension, however it's now a kotlin file, which is why mainApplicationJava is undefined.

I was able to get around this issue by changing this line...

var mainApplicationJava = glob.sync('**/MainApplication.java', ignoreFolders)[0];

to the following:

var mainApplicationJava = glob.sync('**/MainApplication.{java,kt}', ignoreFolders)[0];

This way the glob.sync func matches both file extensions.

@elmalakomar
Copy link

+1

@ArianHamdi
Copy link

Same here

@harunisik
Copy link

+1

@pramahaditamaputra
Copy link

is this issue has been solved ?

@stephanepericat
Copy link

i still have this issue as well

@d4vidi
Copy link
Collaborator

d4vidi commented Jan 28, 2024

All, please track #7834 for the official RN73 support 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests