Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/api/v2 #35

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Feat/api/v2 #35

wants to merge 8 commits into from

Conversation

Tommytrg
Copy link
Member

No description provided.

@Tommytrg Tommytrg force-pushed the feat/api/v2 branch 3 times, most recently from 8452059 to b6792cd Compare November 21, 2023 14:42
hash: data["hash"],
inputAddresses: data["input_addresses"],
outputAddresses: data["output_addresses"],
value: data["value"],
Copy link
Contributor

@gabaldon gabaldon Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we updating ValueTransferInfo and not MintEnty?
The InputUtxo list and ValueTransferOutput list is not accesible anymore in ValueTransferInfo and there is a new field added called value, which is missing in MintEntry.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ValueTransferInfo and MintInfo have different schema. In the case of MintInfo, I just had to add a field, but I could keep the same interface we had before. I'm going to double-check to ensure I'm not missing any field you may need in ValueTransferInfo.

Copy link
Contributor

@gabaldon gabaldon Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the call to get the the vtt info needs to be done anyway /api/search/hash. /api/address/value-transfers now include more fields, the old version of the API just returns the transaction hashes. The schema of the ValueTransferInfo is not correct. It definitely updated, but the schema does not match the updated one.

epoch*: integer
timestamp*: integer
hash*: string
block*: string
confirmed*: boolean
reverted*: boolean
input_addresses*: [string]
input_utxos*: [{
address*: string
value*: integer
Constraints: Min 0
input_utxo*: string
}]
inputs_merged*: [{
address*: string
value*: integer}]
output_addresses*: [string]
output_values*: [integer]
Constraints: Min 1
timelocks*: [integer]
utxos*: [{
address*: string
value*: integer
timelock*: integer
locked*: boolean
}]
utxos_merged*: [{
address*: string
value*: integer
timelock*: integer
locked*: boolean
}]
fee*: integer
value*: integer
priority*: integer
weight*: integer
true_output_addresses*: [string]
change_output_addresses*: [string]
true_value*: integer
change_value*: integer
}

);
}

factory ValueTransferInfo.fromDbJson(Map<String, dynamic> data) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants