Skip to content

Commit

Permalink
updating settings scope
Browse files Browse the repository at this point in the history
So the settings API has settings scopes now and unfortunately the defaults make the setting storable in places it probably doesn't make sense. We might change the defaults later but if we do, this setting won't harm anything and adding it now cleans up the settings usage. I'm going through all my plugins that use the settings to make a similar change now. Relatively small, don't have to kick off a full update, just submitting the change while thinking about it. Related: if you /do/ want to make a new release, I highly recommend: https://github.com/Vector35/release_helper which completely automates the process.
  • Loading branch information
psifertex authored and withzombies committed Jun 4, 2021
1 parent ed90947 commit 5e5412c
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions __init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"title" : "Show Common ILs",
"type" : "boolean",
"default" : true,
"description" : "Show common forms (non-SSA, non-mapped) in the output."
"description" : "Show common forms (non-SSA, non-mapped) in the output.",
"ignore" : ["SettingsProjectScope", "SettingsResourceScope"]
}
""")

Expand All @@ -33,7 +34,8 @@
"title" : "Include MMLIL",
"type" : "boolean",
"default" : false,
"description" : "Show the MappedMediumLevelIL form in the output."
"description" : "Show the MappedMediumLevelIL form in the output.",
"ignore" : ["SettingsProjectScope", "SettingsResourceScope"]
}
""")

Expand All @@ -42,7 +44,8 @@
"title" : "Include SSA",
"type" : "boolean",
"default" : true,
"description" : "Include SSA forms in the output."
"description" : "Include SSA forms in the output.",
"ignore" : ["SettingsProjectScope", "SettingsResourceScope"]
}
""")

Expand Down

0 comments on commit 5e5412c

Please sign in to comment.