Add <LinkButton> component
#1784
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 54beb60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
📚 docs
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
| .sl-markdown-content a:not(:where(:is(.not-content, .not-content *))) { | ||
| color: var(--sl-color-text-accent); | ||
| } | ||
| .sl-markdown-content a:hover:not(:where(.not-content *)) { | ||
| .sl-markdown-content a:hover:not(:where(:is(.not-content, .not-content *))) { |
There was a problem hiding this comment.
These changes are used to avoid <LinkButton> getting Markdown link styles applied to it by specifying the not-content class on the link itself and not a wrapping element.
I'm wondering if this is a change that could be applied to some other places to avoid relying on a wrapping element to avoid Markdown styles 🤔
|
Following the last Talking & Doc'ing session discussions, I updated the pull request to include the following changes:
|
* main: (57 commits) Add type checking job to the CI workflow (withastro#1827) [ci] format i18n(pt-BR): Update `components.mdx` (withastro#1815) [ci] format i18n(ru): update translations (withastro#1825) i18n(pt-BR): Update `css-and-tailwind.mdx` (withastro#1817) i18n(es): updates `pages` (withastro#1823) i18n(es): update `i18n` (withastro#1822) i18n(es): updates `overrides` (withastro#1820) i18n(es): update `guides/components` and add `syncKey` to various pages (withastro#1818) [ci] format i18n(es): update `community-content` (withastro#1824) i18n(es): update `configuration` (withastro#1821) i18n(es): update `frontmatter` (withastro#1819) i18n(fr): update `guides/pages.mdx` (withastro#1800) i18n(fr): update `reference/overrides.md` (withastro#1803) i18n(fr): update `reference/frontmatter.md` (withastro#1802) i18n(fr): update `reference/configuration.mdx` (withastro#1801) i18n(fr): update `guides/i18n.mdx` (withastro#1799) i18n(fr): update `guides/components` and add `syncKey` to various pages (withastro#1797) ...
What kind of changes does this PR include?
Description
This PR adds a new
<LinkButton>component adressing the request in the built-in components discussion.Preview playground page: https://starlight-git-fork-hideoo-hd-feat-link-button-astrodotbuild.vercel.app/guides/components/#link-buttons
Visually, this is almost identical to the internal
<CallToAction>component (now removed and replaced by the new component) that was used for actions in the hero component.The name is still up for discussion, some design system use
CTALinkorCallToActionbut this may not be obvious to everyone. Some others useButtonLinkbut as pointed out by Chris, we already have a<LinkCard>component so this uses the same pattern.Using something like
<Button>may be confusing as this is a link that should be used for navigation and not a form primitive for example.Remaining tasks
docs/src/assets/landing.css)docs/src/content/docs/reference/link-button.mdx)