-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minor type issues in starlight #1706
Conversation
🦋 Changeset detectedLatest commit: d085951 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, super appreciated! 🙌
Left a few comments/questions inline to make sure we properly understand the issues and fix them properly but this is clearly something that needs to be fixed. Thanks for opening up a PR.
378138b
to
1856f63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these fixes and your responsiveness making changes @jorenbroekema! Appreciate the contribution 🌟
Description
Here's the type issues I was getting, skipLibCheck unfortunately doesn't work for TS files (only .d.ts) so this is a real blocker when trying to lint/compile my project which uses starlight.