Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor type issues in starlight #1706

Merged
merged 3 commits into from Apr 9, 2024
Merged

Conversation

jorenbroekema
Copy link
Contributor

Description

  • Closes # N/A didn't create an issue since the PR is so tiny
  • What does this PR change? Fixes some types
  • Did you change something visual? No

Here's the type issues I was getting, skipLibCheck unfortunately doesn't work for TS files (only .d.ts) so this is a real blocker when trying to lint/compile my project which uses starlight.
image

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: d085951

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 9, 2024 11:05am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Apr 2, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, super appreciated! 🙌

Left a few comments/questions inline to make sure we properly understand the issues and fix them properly but this is clearly something that needs to be fixed. Thanks for opening up a PR.

packages/starlight/integrations/shared/pathToLocale.ts Outdated Show resolved Hide resolved
packages/starlight/user-components/rehype-file-tree.ts Outdated Show resolved Hide resolved
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these fixes and your responsiveness making changes @jorenbroekema! Appreciate the contribution 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants