New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(nb): update ui strings and init docs translations #1611
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5785a8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Johannes, great work with this PR. I have not reviewed it with the content itself since I can't understand Norwegian but I have left some suggestions just for some "ordering" if you will 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you bring back older positions for the labels and append the nb
label at the end like how the ukrainian label is in https://github.com/withastro/starlight/blob/main/.github/labeler.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you append nb
related strings at the end and bring other strings back to their original position as in https://github.com/withastro/starlight/blob/main/docs/astro.config.mjs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar append suggestion wrt https://github.com/withastro/starlight/blob/main/docs/lunaria.config.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar append suggestion wrt https://github.com/withastro/starlight/blob/main/docs/package.json
Description
This PR adds a few missing translations for the UI components
fileTree.directory
andaside.*
Since the project supports nb, I started work on also translating the docs into nb as well
It also sorts some of the translation objects to make it easier to find the translation I was looking for